[PWGJE] Add a new histogram for the DCAxy template fit #14609
+98
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynishida-style
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
fjonasALICE
requested changes
Jan 26, 2026
PWGJE/Tasks/jetShape.cxx
Outdated
| registry.fill(HIST("tpcTofPiOutOfJet"), trkP, tpcPi, jet.ptCorr, centrality); | ||
| if (isTpcPiRange) { | ||
| registry.fill(HIST("pVsPtForPiOutOfJet"), trkP, trkPt, jet.ptCorr, centrality); | ||
| registry.fill(HIST("pVsPtForPiOutOfJet"), trkP, trkPt, jet.ptCorr, centrality, track.dcaXY()); |
Collaborator
There was a problem hiding this comment.
while here the DCA is filled in addition, I think where the axes are defined for this histogram, you forgot to add the additional axis for DCA
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment. As you pointed out, this fill was a mistake.
DCAxy is supposed to be filled into dcaPrOutOfJet, and I do not intend to fill DCAxy into jetpVsPtForPr.
Therefore, I removed track.dcaxy() from this line.
PWGJE/Tasks/jetShape.cxx
Outdated
| registry.fill(HIST("tpcTofPrOutOfJet"), trkP, tpcPr, jet.ptCorr, centrality); | ||
| if (isTpcPrRange) { | ||
| registry.fill(HIST("pVsPtForPrOutOfJet"), trkP, trkPt, jet.ptCorr, centrality); | ||
| registry.fill(HIST("pVsPtForPrOutOfJet"), trkP, trkPt, jet.ptCorr, centrality, track.dcaXY()); |
Collaborator
There was a problem hiding this comment.
same comment as above
PWGJE/Tasks/jetShape.cxx
Outdated
| // --- centrality --- | ||
| float centrality = mcCollision.centFT0M(); | ||
| float centrality = collisions.begin().centFT0M(); | ||
| // float centrality = mcCollision.centFT0M(); |
Contributor
Author
There was a problem hiding this comment.
I removed this unused line.
nzardosh
previously approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new histograms including DCAxy axis for the template fit